On Tue, Sep 3, 2013 at 12:04 PM, Jonathan Nieder <jrnie...@gmail.com> wrote: > SZEDER Gábor wrote: >> On Tue, Sep 03, 2013 at 08:39:54AM -0500, Felipe Contreras wrote: > >>> There are two ways to fix an inconsistency, the other way is to fix >>> test_cmp. But that would be a change, and change is not welcome in >>> Git. >> >> It depends on the change, I suppose. I agree, changing 3k+ lines just >> to avoid yoda conditions... I doubt the gain worth the code churn. > > Especially when the idiom being changed is not even being made better. > ;-)
But it is better. > test_cmp_rev follows the same order of arguments a "diff -u" and > produces the same output as plain "git diff". It's perfectly readable > and normal. I think Felipe is pushing buttons and testing boundaries. Those are irrelevant implementation details. -- Felipe Contreras -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
