On Sun, Apr 21, 2013 at 5:00 PM, Junio C Hamano <[email protected]> wrote: > Felipe Contreras <[email protected]> writes: > >> On Sun, Apr 21, 2013 at 2:02 PM, Andreas Schwab <[email protected]> >> wrote: >>> Junio C Hamano <[email protected]> writes: >>> >>>> Andreas Schwab <[email protected]> writes: >>>> >>>>> Felipe Contreras <[email protected]> writes: >>>>> >>>>>> + if [ -n "${ZSH_VERSION-}" ]; then >>>>>> + u="%%" >>>>>> + else >>>>>> + u="%" >>>>>> + fi >>>>> >>>>> aka u="%${ZSH_VERSION:+%}" >>>> >>>> Do you need/want a colon there? Even if it is empty, as long as it >>>> is defined we would want this, no? >>> >>> The original wouldn't. >> >> I thought you were trying to improve the original ;) > > OK, so I _think_ everybody is in agreement that the patch should > look like this. OK? > > -- >8 -- > From: Felipe Contreras <[email protected]> > Subject: [PATCH] prompt: fix untracked files for zsh > > With "bash.showUntrackedFiles" option,
Not exactly correct, it can also be GIT_PS1_SHOWUNTRACKEDFILES. > presense of untracked files > is signalled by adding a per-cent sign '%' to the prompt. But > because '%' is used as an escape character to introduce prompt > customization in zsh (just like bash prompt uses '\' to escape \u, > \h, etc.), we need to say '%%' to get a literal per-cent. Otherwise it's fine. Cheers. -- Felipe Contreras -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
