On Fri, Mar 22, 2013 at 07:54:06AM -0700, Junio C Hamano wrote:

> Ramkumar Ramachandra <artag...@gmail.com> writes:
> 
> >  mk_empty () {
> > -   rm -fr testrepo &&
> > -   mkdir testrepo &&
> > +   repo_name="$1"
> > +   test -z "$repo_name" && repo_name=testrepo
> > +   rm -fr $repo_name &&
> > +   mkdir $repo_name &&
> 
> Your quoting is sloppy in this entire patch X-<.

I meant to mention that, too. It doesn't matter, as the intent is for it
always to be a simple name like "testrepo", but that assumption is not
documented anywhere. I suspect the quoting in my patch is sloppy, too.

-Peff
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to