Hi Junio, On Thu, 14 Mar 2013, Junio C Hamano wrote:
> Erik Faye-Lund <kusmab...@gmail.com> writes: > > > diff --git a/http.c b/http.c > > index 3b312a8..528a736 100644 > > --- a/http.c > > +++ b/http.c > > @@ -343,7 +343,8 @@ void http_init(struct remote *remote, const char *url, > > int proactive_auth) > > > > git_config(http_options, NULL); > > > > - curl_global_init(CURL_GLOBAL_ALL); > > + curl_global_init(CURL_GLOBAL_WIN32 | (prefixcmp(url, "https:") ? 0 : > > + CURL_GLOBAL_SSL)); > > The first and obvious question is what the symbol with a name > specific to one single platform doing in this generic codepath. > In order to get convinced that the patch does not regress, one > somehow need to know that bits in ALL other than WIN32 and SSL > do not matter (or there is no such bit). > > I'd understand if it were "ALL & ~SSL" though. Hence my earlier suggestion (with the obvious tyop '^' instead of '~'). You will also find the information in my mail (unless you plonk my mails) that CURL_GLOBAL_ALL is defined as CURL_GLOBAL_WIN32 | CURL_GLOBAL_SSL, and in kusma's response the suggestion to use DEFAULT & ~SSL instead. Ciao, Johannes -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
