SZEDER Gábor <szeder....@gmail.com> writes:

>  skip_good_tree () {
> +     if test "$TRAVIS_DEBUG_MODE" = true
> +     then
> +             return
> +     fi

I think you convinced readers why it is a good idea to avoid
skipping an already tested tree, and technically the title of this
commit is not incorrect per-se.  You are teaching to ignore
"already-tested-ness" from a part of the logic).

But in the larger picture, I would expect that readers would more
immediately grasp what it is about if it were titled "do not skip
versions that have already tested good in debug mode" or something
like that (IOW, we do not want to ignore such trees, we want to test
them again).

Reply via email to