On 8/29/2019 8:43 PM, Taylor Blau wrote: > Hi Elijah, > > On Thu, Aug 29, 2019 at 05:19:44PM -0700, Elijah Newren wrote: >> Personally, although I understand the desire to support any possible >> cases in general, *this is a performance hack*. As such, it should be >> as simple and localized as possible. I don't think supporting >> old-style stuck flags (-b$BRANCH) is worth complicating this. I'm >> even leery of adding support for --track (do any users of huge repos >> use -b with --track? Does anyone at all use --track anymore? I'm not >> sure I've ever seen any user use that flag in the last 10 years other >> than myself.) Besides, in the *worst* possible case, the command the >> user specifies works just fine...it just takes a little longer. My >> opinion is that Stolee's patch is perfect as-is and should not be >> generalized at all. > > I wholeheartedly agree with this, and pledge my $.02 towards it as well. > Now with a combined total of $.04, I think that this patch is ready for > queueing as-is.
Thanks, both!
