On Mon, Aug 05, 2019 at 09:57:19AM -0400, Derrick Stolee wrote:
> On 8/5/2019 4:02 AM, SZEDER Gábor wrote:
> > While 'git commit-graph write --stdin-commits' expects commit object
> > ids as input, it accepts and silently skips over any invalid commit
> > object ids, and still exits with success:
> >
> > # nonsense
> > $ echo not-a-commit-oid | git commit-graph write --stdin-commits
> > $ echo $?
> > 0
> > # sometimes I forgot that refs are not good...
> > $ echo HEAD | git commit-graph write --stdin-commits
> > $ echo $?
> > 0
> > # valid tree OID, but not a commit OID
> > $ git rev-parse HEAD^{tree} | git commit-graph write --stdin-commits
> > $ echo $?
> > 0
> > $ ls -l .git/objects/info/commit-graph
> > ls: cannot access '.git/objects/info/commit-graph': No such file or
> > directory
> >
> > Check that all input records are indeed valid commit object ids and
> > return with error otherwise, the same way '--stdin-packs' handles
> > invalid input; see e103f7276f (commit-graph: return with errors during
> > write, 2019-06-12).
>
> Consistency is good. We should definitely make these modes match.
I was also wondering whether it would be worth accepting refs as well,
either as DWIMery or only when a '--revs' option is given (similar to
'git pack-objects --revs'). Dunno, I'm a bit hesitant about always
accepting refs as a DWIMery, this is plumbing after all. And I don't
really care whether I correct my bogus command by replacing 'echo'
with 'git rev-parse' or by adding a '--revs' argument; the important
thing is that the command should tell me that I gave it junk. And
that would be a new feature, while this patch is a bugfix IMO.
> > Note that it should only return with error when encountering an
> > invalid commit object id coming from standard input. However,
> > '--reachable' uses the same code path to process object ids pointed to
> > by all refs, and that includes tag object ids as well, which should
> > still be skipped over. Therefore add a new flag to 'enum
> > commit_graph_write_flags' and a corresponding field to 'struct
> > write_commit_graph_context', so we can differentiate between those two
> > cases.
>
> Thank you for the care here.
Well, to be honest, I wasn't careful... :) but running the test suite
with GIT_TEST_COMMIT_GRAPH=1 resulted in about a dozen failed test
scripts that traced back to this.
