On Sun, Jul 28, 2019 at 9:57 PM Junio C Hamano <gits...@pobox.com> wrote: > > I am not sure I like a config-only knob like this, > though---shouldn't we have a command line knob to turn jit off > first, and then for those who gets tired of having to type it all > the time add the configuration to flip the default for them?
are you suggesting to add a --pcre-jit parameter to both grep and log? guess using pcre.jit for the configuration makes sense as far as it is documented on both man pages, or would this imply this should go instead into core? I was expecting this to be set system (or at least global) wide most of the time like (ex: core.ignorecase, credential.helper) neither of which I can relate to a command line parameter. > Other than that, the feature itself makes quite a lot of sense. should I target maint/master?, next conflicts because of ab/no-kwset and it also conflicts with other in fly features too (some not even in pu), which is why now is based on pu and depends on ab/pcre-jit-fixes Carlo
