Hi Stolee, On Wed, 24 Jul 2019, Derrick Stolee via GitGitGadget wrote:
> diff --git a/builtin/update-index.c b/builtin/update-index.c > index dff2f4b837..5ced51c1ee 100644 > --- a/builtin/update-index.c > +++ b/builtin/update-index.c > @@ -18,6 +18,7 @@ > #include "dir.h" > #include "split-index.h" > #include "fsmonitor.h" > +#include "repo-settings.h" Sorry, I only realized 10 seconds ago that these `#include`s are no longer necessary because `repo-settings` is already included from `repository.h` (and needs to be, because the `repository` struct now contains a full `struct repo_settings` field, no longer just a pointer). But really, I would just fold the `repo-settings.h` declarations directly into `repository.h` (but keep `repo-settings.c`, of course!) as it make everything a bit simpler. Thanks, Dscho
