On Thu, Jun 27, 2019 at 12:54:15AM -0400, Eric Sunshine wrote:
> On Wed, Jun 26, 2019 at 7:51 PM Emily Shaffer <emilyshaf...@google.com> wrote:
> > For now, we have no configuration options we want to set up for
> > ourselves, but in the future we may need to. At the very least, we
> > should invoke git_default_config() for each config option; we will do so
> > inside of a skeleton config callback so that we know where to add
> > configuration handling later on when we need it.
> >
> > Signed-off-by: Emily Shaffer <emilyshaf...@google.com>
> > ---
> > diff --git a/builtin/walken.c b/builtin/walken.c
> > @@ -24,11 +25,36 @@ const char * const walken_usage[] = {
> > static void init_walken_defaults(void)
> > {
> > /*
> > - * We don't actually need the same components `git log` does; leave
> > this
> > - * empty for now.
> > + * We don't use any other components or have settings to
> > initialize, so
> > + * leave this empty.
> > */
> > }
>
> Meh, I don't think this change has anything to do with this patch. If
> the rewritten text is the one you prefer, then just introduce it like
> that in patch 3/13 where the function itself was introduced.
Whoops, yeah. I removed this change, I don't think it's significant.
