On Tue, Jun 18, 2019 at 8:24 AM Jeff Hostetler via GitGitGadget <gitgitgad...@gmail.com> wrote: > This special-cases various signals that are not supported on Windows, > such as SIGPIPE. These cause the UCRT to throw asserts (at least in > debug mode). > > Signed-off-by: Jeff Hostetler <jeffh...@microsoft.com> > Signed-off-by: Johannes Schindelin <johannes.schinde...@gmx.de> > --- > diff --git a/compat/mingw.c b/compat/mingw.c > @@ -2119,8 +2119,34 @@ int mingw_raise(int sig) > +#if defined(_MSC_VER) > + /* > + * <signal.h> in the CRT defines 8 signals as being > + * supported on the platform. Anything else causes > + * an "Invalid signal or error" (which in DEBUG builds > + * causes the Abort/Retry/Ignore dialog). We by-pass > + * the CRT for things we already know will fail. > + */ > + /*case SIGINT:*/ > + case SIGILL:
Why is SIGINT commented out? And, the comment block seems over-indented. > + case SIGFPE: > + case SIGSEGV: > + case SIGTERM: > + case SIGBREAK: > + case SIGABRT: > + case SIGABRT_COMPAT: > + return raise(sig); > + default: > + errno = EINVAL; > + return -1;
