Duy Nguyen <pclo...@gmail.com> writes: > On Mon, May 20, 2019 at 8:17 PM Jeff King <p...@peff.net> wrote: >> The patch looks good, though I wonder if we could simplify even further >> by just embedding an index into the repository object. The purpose of >> having it as a pointer, I think, is so that the_repository can point to >> the_index. But we could possibly hide the latter behind some macro >> trickery like: >> >> #define the_index (the_repository->index) > ... >> So it's definitely non-trivial to go that way. I'm not sure if it's >> worth the effort to switch at this point, but even if it is, your patch >> seems like a good thing to do in the meantime.
Yeah, the fact that the_reopsitory->index is not an embedded instance has bothered me from the very beginning, and I am happy to see others share the same feeling ;-) >> Either way, I think we could probably revert the non-test portion of my >> 581d2fd9f2 (get_oid: handle NULL repo->index, 2019-05-14) after this. > > Yeah. I'm thinking of doing that after, scanning for similar lines > too. But it looks like it's the only one. Will fix in v2. Thanks.
