On Thu, May 16, 2019 at 09:37:36AM +0900, Mike Hommey wrote: > use_pack has its own error message on mmap error, but it can't be > reached when using xmmap, which dies with its own error.
Makes sense. Amusingly this xmmap comes from c4712e4553 (Replace mmap with xmmap, better handling MAP_FAILED., 2006-12-24), which specifically moved everything to xmmap for its error handling, and dropped all of the MAP_FAILED checks. But it forgot to remove this one. So we could also go the other way, and just remove the unreachable check. I do think the error from use_pack() is better though, so I like the direction you went. -Peff
