On Wed, May 01, 2019 at 06:01:08AM -0400, Denton Liu wrote: > > I guess we could also simply declare that *all* Coccinelle patches should > > leave `compat/` alone, on the basis that those files are likely coming > > from some sort of upstream. But then, `compat/mingw.c` and `compat/win32/` > > seem not to fall into that category... > > Deciding whether this is a good idea is above my paygrade ;)
FWIW, this seems like a good idea to me. It's _possible_ there may be some cocci changes that we want to apply even to compat/ (e.g., if we're mechanically fixing up a construct with security implications). But whoever is doing that conversion should probably apply that manually (and we don't typically change imported stuff in the first place, so there's little need to subsequently run the cocci patches). > -- >8 -- > Subject: [PATCH] Makefile: filter out compat/ from coccicheck > [...] The patch itself looks OK to me. -Peff
