On Mon, Feb 25, 2019 at 12:32:49PM -0500, Jeff King wrote:
> diff --git a/line-log.c b/line-log.c
> index 24e21731c4..863f5cbe0f 100644
> --- a/line-log.c
> +++ b/line-log.c
> @@ -1106,7 +1106,8 @@ int line_log_print(struct rev_info *rev, struct commit 
> *commit)
>       struct line_log_data *range = lookup_line_range(rev, commit);

Note that the result of this lookup_line_range() call is only used
when we do show the diff below; if we don't, there is no use calling
it.

>       show_log(rev);
> -     dump_diff_hacky(rev, range);
> +     if (!(rev->diffopt.output_format & DIFF_FORMAT_NO_OUTPUT))
> +             dump_diff_hacky(rev, range);
>       return 1;
>  }
>  

Reply via email to