[PATCH 01/26] bisect--helper: refer branch.buf before strbuf_release(...)

[Tanushree Tumane via GitGitGadget]

From: Tanushree Tumane <tanushreetum...@gmail.com>

move `error("...%s...", branch.buf);` before `strbuf_release(&branch);`.

add ' ' before "reset.." in error message.

Mentored-by: Johannes Schindelin <johannes.schinde...@gmx.de>
Mentored-by: Christian Couder <chrisc...@tuxfamily.org>
Signed-off-by: Tanushree Tumane <tanushreetum...@gmail.com>
---
 builtin/bisect--helper.c | 7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)

diff --git a/builtin/bisect--helper.c b/builtin/bisect--helper.c
index 22e669e3b1..e672ee9f18 100644
--- a/builtin/bisect--helper.c
+++ b/builtin/bisect--helper.c
@@ -169,11 +169,12 @@ static int bisect_reset(const char *commit)
 
                argv_array_pushl(&argv, "checkout", branch.buf, "--", NULL);
                if (run_command_v_opt(argv.argv, RUN_GIT_CMD)) {
+                       error(_("could not check out original"
+                               " HEAD '%s'. Try 'git bisect"
+                               " reset <commit>'."), branch.buf);
                        strbuf_release(&branch);
                        argv_array_clear(&argv);
-                       return error(_("could not check out original"
-                                      " HEAD '%s'. Try 'git bisect"
-                                      "reset <commit>'."), branch.buf);
+                       return -1;
                }
                argv_array_clear(&argv);
        }
-- 
gitgitgadget