On Fri, Feb 22, 2019 at 3:11 PM Junio C Hamano <gits...@pobox.com> wrote:
> diff --git a/builtin/log.c b/builtin/log.c
> @@ -911,7 +911,7 @@ static void get_patch_ids(struct rev_info *rev, struct
> patch_ids *ids)
> if (rev->pending.nr != 2)
> - die(_("Need exactly one range."));
> + die(_("need exactly one range."));
Perhaps drop the trailing period while you're here?
> @@ -921,7 +921,7 @@ static void get_patch_ids(struct rev_info *rev, struct
> patch_ids *ids)
> if ((flags1 & UNINTERESTING) == (flags2 & UNINTERESTING))
> - die(_("Not a range."));
> + die(_("not a range."));
Ditto.
> @@ -1331,16 +1331,16 @@ static struct commit *get_base_commit(const char
> *base_commit,
> if (get_oid(upstream, &oid))
> - die(_("Failed to resolve '%s' as a valid
> ref."), upstream);
> + die(_("failed to resolve '%s' as a valid
> ref."), upstream);
Ditto.
> if (!base_list || base_list->next)
> - die(_("Could not find exact merge base."));
> + die(_("could not find exact merge base."));
Ditto.
> - die(_("Failed to get upstream, if you want to record
> base commit automatically,\n"
> + die(_("failed to get upstream, if you want to record
> base commit automatically,\n"
> "please use git branch --set-upstream-to to
> track a remote branch.\n"
> "Or you could specify base commit by
> --base=<base-commit-id> manually."));
The capitalized "Or you..." is odd after s/Failed/failed/. I wonder if
the period in the first sentence should be replaced by a semicolon and
then "Or you..." downcased (and the final period dropped):
die(_("failed to ... automatically,\n"
"please use ... branch;\n"
"or you ... manually"));
