Jeff King <[email protected]> writes:
> I've run across this many times, too. Since it's been bugging me for a
> decade, I thought I'd finally try to address it. Here are some patches.
>
> There was some discussion about a year ago about just using "git show"
> for this output:
>
>
> https://public-inbox.org/git/cap8ufd3qhtuj+j3vbgrm0stq2dsols-m2_pwfj6dzs4vzhk...@mail.gmail.com/
>
> Christian seemed generally OK with tweaking the output, but preferred
> not to move all the way to running an external "git show". I'm not sure
> I completely agree, but it was easy enough to get the results I wanted
> just by fiddling the current code a bit. ;)
>
> [1/3]: bisect: use string arguments to feed internal diff-tree
> [2/3]: bisect: fix internal diff-tree config loading
> [3/3]: bisect: make diff-tree output prettier
>
> bisect.c | 19 +++++--------------
> t/t6030-bisect-porcelain.sh | 6 +++---
> 2 files changed, 8 insertions(+), 17 deletions(-)
Looks good from a quick glance.
One unrelated thing that made me curious was that the output from
git grep 'is the first '
had these two lines:
bisect.c: printf("%s is the first %s commit\n",
oid_to_hex(bisect_rev),
git-bisect.sh: if sane_grep "is the first $TERM_BAD commit"
"$GIT_DIR/BISECT_RUN" >/dev/null
which means that we cannot localize this message without thought,
unlike the usual "hey, this is end-user facing, so wrap it in _()
out of spinal reflex."
