On Thu, Feb 14, 2019 at 11:06:34AM -0800, Jonathan Tan wrote: > Peff noticed an issue with my http auth in protocol v2 patch earlier > [1], and in the ensuing discussion, I thought that it would be best to > make v2 use post_rpc() as well (to be the same as v0/v1) instead of > using its own functions, to fix this issue and try to avoid a similar > issue in the future. Besides that, there is also a net reduction in > lines of code. > > So here are the patches. First 4 are refactoring - the last one has the > actual change. This is on the master branch.
I think this is the right approach. Patches 1-4 look pretty nice. I didn't see anything wrong with the code in the 5th one, but I did have some thoughts about how we might be able to do it a bit more cleanly (though I will not at all be surprised if they turn out to be bad suggestions). -Peff
