> * jt/test-protocol-version (2019-02-06) 9 commits > - remote-curl: in v2, fill credentials if needed > - t5552: compensate for v2 filtering ref adv. > - tests: fix protocol version for overspecifications > - t5700: only run with protocol version 1 > - t5512: compensate for v0 only sending HEAD symrefs > - t5503: fix overspecification of trace expectation > - tests: always test fetch of unreachable with v0 > - tests: define GIT_TEST_PROTOCOL_VERSION > - Merge branch 'js/protocol-advertise-multi' into jt/test-protocol-version > (this branch uses js/protocol-advertise-multi.) > > Help developers by making it easier to run most of the tests under > different versions of over-the-wire protocols. > > Blocked by js/protocol-advertise-multi
If you don't mind, remove the last patch (remote-curl: in v2, fill credentials if needed) from this set. Peff noticed some issues with it, and I have sent out a separate set [1] that better fixes the issue. Peff also noticed [2] a minor issue with patch 1 - I used strlen(git_test_v) instead of *git_test_v to check that it is non-empty - but that might not be worth a reroll. Other than that, this set (with the exception of the last patch that I asked you to remove in the first paragraph) looks good to Peff [3] and me (besides being blocked by js/protocol-advertise-multi). [1] https://public-inbox.org/git/[email protected]/ [2] https://public-inbox.org/git/[email protected]/ [3] https://public-inbox.org/git/[email protected]/
