Patrick Hogg <ph...@novamoon.net> writes: > As I mentioned in the prior thread I think that it will be simpler > to simply use the existing lock in packing_data instead of moving > read_mutex. I can go back to simply moving read_mutex to the > packing_data struct if that that is preferable, though.
I'll let others comment on this to show preference between the two approaches. > I also removed the #ifndef NO_PTHREADS in prepare_packing_data around > the initialization of &pdata->lock since I had to upgrade the lock to > a recursive mutex. As far as I can tell init_recursive_mutex (and > pthread_mutex_init for that matter) have that protection already so it > appears to be redundant. If you can defer "I also" to a separate patch, please do so. Keeping the fix alone as small as possible and not tangled with other changes would make it easier for people to cherry-pick the fix to older maintenance tracks if they choose to.
