Christian Couder <christian.cou...@gmail.com> writes: > On Mon, Jan 7, 2019 at 1:53 PM Duy Nguyen <pclo...@gmail.com> wrote: >> >> On Sun, Jan 6, 2019 at 10:46 PM Christian Couder >> <christian.cou...@gmail.com> wrote: >> > >> > It looks like it is a copy-paste error made in 80f2a6097c >> > (t/helper: add test-ref-store to test ref-store functions, >> > 2017-03-26) to pass "old-sha1" instead of "new-sha1" to >> > notnull() when we get the new sha1 argument from >> > const char **argv. >> >> Ack. Definitely copy-paste error. > > Thanks for confirming. > > Junio, it looks like the patch has fallen through the cracks.
Indeed. I did notice two smallish cleanups from you but did not spot this one. Will take a look and queue. Thanks. > > Or maybe I should rework the commit message?
