Junio C Hamano <gits...@pobox.com> writes:

> Lack of corresponding comment bothers readers.  In all of
> REMOTE_ERROR, PROGRESS and PROTOCOL_ERROR cases, the other helper
> stuffs the message in outbuf in "switch (band) { ... }" and writes
> it out with xwrite(2, outbuf.buf, outbuf.len) [*1*], so I can see
> there is no need for us to write anything out here.  Perhaps
>
>               case SIDEBAND_FLUSH:
>               default: /* errors: message already written */
>                       return retval;
>
> or something to clarify?

Forgot a footnote for *1* above.  I was wondering if xwrite is what
we really want, rather than write_in_full().

Reply via email to