On Sun, Jan 27, 2013 at 11:49:39AM -0800, Junio C Hamano wrote: > John Keeping <j...@keeping.me.uk> writes: > > > When this change was originally made (0846b0c - git-remote-testpy: hash > > bytes explicitly , I didn't realised that the "hex" encoding we chose is > > a "bytes to bytes" encoding so it just fails with an error on Python 3 > > in the same way as the original code. > > > > It is not possible to provide a single code path that works on Python 2 > > and Python 3 since Python 2.x will attempt to decode the string before > > encoding it, which fails for strings that are not valid in the default > > encoding. Python 3.1 introduced the "surrogateescape" error handler > > which handles this correctly and permits a bytes -> unicode -> bytes > > round-trip to be lossless. > > > > At this point Python 3.0 is unsupported so we don't go out of our way to > > try to support it. > > > > Helped-by: Michael Haggerty <mhag...@alum.mit.edu> > > Signed-off-by: John Keeping <j...@keeping.me.uk> > > --- > > Thanks; will queue and wait for an Ack from Michael. > > Does the helper function need to be named with leading underscore, > though?
It's a Python convention for internal functions. Since this is a script not a library module I don't feel strongly about it in this case. John -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
