On Tue, Nov 27, 2018 at 10:48 AM Carlo Arenas <care...@gmail.com> wrote: > On Tue, Nov 27, 2018 at 2:53 AM Eric Sunshine <sunsh...@sunshineco.com> wrote: > > On Tue, Nov 27, 2018 at 5:06 AM Carlo Marcelo Arenas Belón > > > +ifneq ($(filter clang10,$(COMPILER_FEATURES)),) > > > +CFLAGS += -Wpedantic > > > +endif > > > > Should this condition be tightened to match only for OSX since there > > is no such clang version number in the rest world outside of Apple? > > instead, I changed it to clang4 and tested it in a FreeBSD 11 box I > was able to get a hold off, would that work better? > will update patch accordingly then
Playing Devi's Advocate, what if Apple's clang "8" was, in reality, real-world clang 3? Then this condition would incorrectly enable the compiler option on Apple for a (real) clang version below 4. For this reason, it seems we shouldn't be trusting only the clang version number when dealing with Apple. (I suspect that it won't make a difference in actual practice, so it may be reasonable to punt on this issue until/if someone complains.)
