On Wed, Nov 14, 2018 at 12:42:45AM +0000, Ramsay Jones wrote:
> BTW, if you were puzzling over the 3rd symbol from sha1-file.o
> (which I wasn't counting in the 4 symbols above! ;-) ), then I
> believe that is because Jeff's commit 3a2e08245c ("object-store:
> provide helpers for loose_objects_cache", 2018-11-12) effectively
> moved the only call outside of sha1-file.c (in sha1-name.c) back
> into sha1-file.c
>
> So, for_each_file_in_obj_subdir() could now be marked 'static'.
> (whether it should is a different issue).
I think it would be reasonable to do so. Most code shouldn't have to
care about the on-disk hashing structure, so ideally it wouldn't be part
of the public interface.
-Peff
