On Fri, Oct 19, 2018 at 06:53:01PM +0200, Duy Nguyen wrote: > > OK, that all makes sense. I need to either drop it or mark it unused to > > satisfy -Wunused-parameters. > > Aha! I thought you looked deeply into this and was very confused. How > could you have found the time :D
To be fair, dealing with -Wunused-parameters is its own special time sink. :) > > I think I'd lean toward the former, if > > it's not likely to be used (even if we add "struct repository" later, > > the separate index parameter would just go away then). > > Or we could fix it now. Something like this? It adds three the_repository > (two technically are already there) but deletes eight, which makes me > happy. It's up to you to decide. Yeah, that's fine by me, if it's not getting in the way of other related work. The patch you sent looks reasonable. -Peff
