On Mon, Oct 15, 2018 at 09:31:54PM +0200, Jacques Bodin-Hullin wrote: > I've just updated the PR with the `error(` change. > > Also I did the change for the question mark at the end, because you are > right, when we read it, it sounds better. > > Do I need to put back the patch in this thread? It's here: > https://patch-diff.githubusercontent.com/raw/git/git/pull/540.patch
The commit looks good, though you may want to expand the commit message a little (it's not really a typo, but more of a style fix). The next step would normally be to send the patch to the list (ideally in this thread), with "[PATCH v2]" in the subject. It looks like you're using SubmitGit. I don't remember offhand how it works for sending re-rolls like this, but I think it's possible. If you run into trouble, you might try instead using GitGitGadget, which is a similar PR->mail gateway that is a little more featureful: https://github.com/gitgitgadget/gitgitgadget -Peff
