On Thu, Oct 04, 2018 at 03:52:05PM -0700, Jonathan Tan wrote: > > Or I am even OK with leaving the existing tablesize > > check. It is a little intimate with the implementation details, but I > > suspect that if oidset were to change (e.g., to initialize the buckets > > immediately), the problem would be pretty apparent in the tests. > > I am OK with this too, except that (as far as I can tell) the point of > this patch set is to replace the internals of oidset, so we no longer > have the tablesize check. Unless you meant the khash analog of > tablesize? I would be OK if all tablesize references are replaced with > the khash analog in the same patch that the oidset internals are > replaced.
Yeah, in khash it's n_buckets, but it's basically the same thing. René's original patch did that update, and we were musing on whether there was a way to avoid crossing the module boundary so intimately. Hence the patch you saw. :) -Peff
