Hi Eric,

On Mon, 3 Sep 2018, Eric Sunshine wrote:

> On Mon, Sep 3, 2018 at 5:10 PM Johannes Schindelin via GitGitGadget
> <gitgitgad...@gmail.com> wrote:
> > The upcoming patches will allow building git.git via VSTS CI, where
> > variable names and URLs look a bit different than in Travis CI.
> >
> > Signed-off-by: Johannes Schindelin <johannes.schinde...@gmx.de>
> > ---
> > diff --git a/ci/install-dependencies.sh b/ci/install-dependencies.sh
> > @@ -28,7 +28,8 @@ osx-clang|osx-gcc)
> >         # Uncomment this if you want to run perf tests:
> >         # brew install gnu-time
> > -       brew install git-lfs gettext
> > +       test -z "$BREW_INSTALL_PACKAGES" ||
> > +       eval brew install $BREW_INSTALL_PACKAGES
> 
> This 'eval' is unnecessary, isn't it?
> 
>     brew install $BREW_INSTALL_PACKAGES
> 
> should give the same result.

Oh right! Fixed in https://github.com/gitgitgadget/git/pull/31 (and I also
opened https://github.com/git/git/pull/531 to verify that Travis CI still
works).

Thanks,
Dscho

> >         brew link --force gettext
> >         brew install caskroom/cask/perforce
> > diff --git a/ci/lib.sh b/ci/lib.sh
> > @@ -1,5 +1,26 @@
> > +       BREW_INSTALL_PACKAGES="git-lfs gettext"
> 

Reply via email to