Ævar Arnfjörð Bjarmason <[email protected]> writes: > Fix up a logic error in 380efb65df ("push tests: assert re-pushing > annotated tags", 2018-07-31), where the $tag_type_description variable > was assigned to but never used, unlike in the subsequently added > companion test for fetches in 2d216a7ef6 ("fetch tests: add a test for > clobbering tag behavior", 2018-04-29). > > Signed-off-by: Ævar Arnfjörð Bjarmason <[email protected]> > --- > t/t5516-fetch-push.sh | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/t/t5516-fetch-push.sh b/t/t5516-fetch-push.sh > index 539c25aada..62d5059f92 100755 > --- a/t/t5516-fetch-push.sh > +++ b/t/t5516-fetch-push.sh > @@ -969,7 +969,7 @@ test_force_push_tag () { > tag_type_description=$1 > tag_args=$2 > > - test_expect_success 'force pushing required to update lightweight tag' " > + test_expect_success 'force pushing required to update > $tag_type_description' "
Of course, $1 needs to be inside "dq-pair" for $tag_type_description to be substituted ;-) So I'll tweak it while queuing. All the other ones in this series looked sensible to me. Will replace. Thanks. > mk_test testrepo heads/master && > mk_child testrepo child1 && > mk_child testrepo child2 &&
