Hi Jonathan, On Tue, 28 Aug 2018, Jonathan Nieder wrote:
> Johannes Schindelin wrote: > > On Mon, 27 Aug 2018, Junio C Hamano wrote: > >> Johannes Schindelin <johannes.schinde...@gmx.de> writes: > >>> Jonathan Nieder wrote: > > >>>> Please include this information in the commit message. It's super > >>>> helpful to find this kind of information about why a patch does what > >>>> it does when encountering a patch later "in the wild" (in git log -S > >>>> output). > [...] > >> I think what Jonathan finds helpful is the other half of the story > > > > I will await Jonathan's clarification. > > Junio's understanding is correct. > > More generally, I greatly appreciate the kind of motivation and > backstory that you write in cover letters, and I wish that more of > that would find its way into the commit messages instead. Really I > wish (and don't take this the wrong way --- I am not asking you to > write it unless it's your own itch) that GitGitGadget would put the > cover letter in single-patch series after the "---" line in the > individual patches, since that would make it easier for reviewers to > point out what content from the cover letter would be useful to add to > the commit message. > > That said, this is minor and not a reason to reroll this patch. It was > more that I wanted to give the hint for later patches. > > Thanks much and hope that helps, It does. I'll "rick-roll" a new iteration, as I just realized that (contrary to my recollection; I guess I'll need that vacation) the commit message is *seriously* lacking. I thought I had remembered that I copy-edited the commit message into the PR description. Clearly that was not the case. Thanks for the clarification that triggered my looking, Dscho
