On Mon, Aug 13, 2018 at 5:15 AM Johannes Schindelin <johannes.schinde...@gmx.de> wrote: > > Hi Stefan, > > On Fri, 10 Aug 2018, Stefan Beller wrote: > > > For now just change the signature, we'll reason about the actual > > change in a follow up patch. > > > > Pass 'set_sign' (which is output before the sign) and 'set' which > > controls the color after the first character. Hence, promote any > > 'set's to 'set_sign' as we want to have color before the sign > > for now. > > I'll freely admit that I had to study the diff in order to understand this > paragraph. > > My I suggest something along those lines instead? > > Split the meaning of the `set` parameter that is passed to > `emit_line_0()` to separate between the color of the "sign" (i.e. > the diff marker '+', '-' or ' ' that is passed in as the `first` > parameter) and the color of the rest of the line. > > This changes the meaning of the `set` parameter to no longer refer > to the color of the diff marker, but instead to refer to the color > of the rest of the line. A value of `NULL` indicates that the rest > of the line wants to be colored the same as the diff marker. >
That is a wonderful commit message, I'll just use it as-is. Thanks, Stefan
