Jeff King <p...@peff.net> writes: > The problem introduced in that commit is that each iteration through the > loop advances the tree pointers.
Ah, indeed. The original used tree_entry_extract() and update_tree_entry() separately, but the update does tree_entry() on both sides. > So the assertion in that commit message that "the calls to > update_tree_entry() are not needed any more" is just wrong. We have > decide whether to call it based on the "cmp" value. Yup.
