On Fri, Jul 27, 2018 at 2:40 AM Stefan Beller <sbel...@google.com> wrote: > > Currently the refs API takes a 'ref_store' as an argument to specify > which ref store to iterate over; however it is more useful to specify > the repository instead (or later a specific worktree of a repository).
There is no 'later'. worktrees.c already passes a worktree specific ref store. If you make this move you have to also design a way to give a specific ref store now. Frankly I still dislike the decision to pass repo everywhere, especially when refs code already has a nice ref-store abstraction. Some people frown upon back pointers. But I think adding a back pointer in ref-store, pointing back to the repository is the right move. -- Duy
