On 25.07.18 18:57, Junio C Hamano wrote: > Beat Bolli <dev+...@drbeat.li> writes: > >> In the interest of code hygiene, make it easier to compile Git with the >> flag -pedantic. >> >> Pure pedantic compilation with GCC 7.3 results in one warning per use of >> the translation macro `N_`: >> >> warning: array initialized from parenthesized string constant >> [-Wpedantic] >> >> Therefore also disable the parenthesising of i18n strings with >> -DUSE_PARENS_AROUND_GETTEXT_N=0. >> >> Signed-off-by: Beat Bolli <dev+...@drbeat.li> >> --- > > Hmph, what did you change between v3 and v4?
Just the commit text. In v3, it still said =No instead of =0. >> diff --git a/Makefile b/Makefile >> index 0cb6590f24..2bfc051652 100644 >> --- a/Makefile >> +++ b/Makefile >> @@ -484,6 +484,12 @@ all:: > > The postimage of this hunk is supposed to be 11 lines long, as you > have five additional line in the middle of 6 original context lines. > Where did this 12 come from? I am only interested in finding out if > our patch generation tool(s) have some bugs with this question. > > If this is only because you hand-edit your patch, then we have no > tool breakage to worry about, but please refrain from doing so in > the future (instead always go back to the commit, amend it, and > re-run format-patch). > > Thanks. You got me there :-/ Won't happen again, sorry. >> # The DEVELOPER mode enables -Wextra with a few exceptions. By >> # setting this flag the exceptions are removed, and all of >> # -Wextra is used. >> +# >> +# pedantic: >> +# >> +# Enable -pedantic compilation. This also disables >> +# USE_PARENS_AROUND_GETTEXT_N to produce only relevant warnings. >> >> GIT-VERSION-FILE: FORCE >> @$(SHELL_PATH) ./GIT-VERSION-GEN >
