On Thu, Jul 12, 2018 at 02:22:14PM +0200, SZEDER Gábor wrote: > diff --git a/t/t5541-http-push-smart.sh b/t/t5541-http-push-smart.sh > index a2af693068..5c9ca19401 100755 > --- a/t/t5541-http-push-smart.sh > +++ b/t/t5541-http-push-smart.sh > @@ -38,6 +38,10 @@ GET > /smart/test_repo.git/info/refs?service=git-upload-pack HTTP/1.1 200 > POST /smart/test_repo.git/git-upload-pack HTTP/1.1 200 > EOF > test_expect_success 'no empty path components' ' > + # Clear the log, so that it does not affect the "used receive-pack > + # service" test which reads the log too. > + test_when_finished ">\"$HTTPD_ROOT_PATH\"/access.log" &&
I think you want to escape the $ here, too, so the eval sees the variable and not its expanded value. Other than that, this iteration looks good (and patch 3 is much easier to read). -Peff
