Hi Junio,
On Wed, 27 Jun 2018, Junio C Hamano wrote:
> Johannes Schindelin <johannes.schinde...@gmx.de> writes:
>
> > git rev-list --bisect-all --first-parent F..E >revs &&
> > # only E, e1..e8 should be listed, nothing else
> > test_line_count = 9 revs &&
> > for rev in E e1 e2 e3 e4 e5 e6 e7 e8
> > do
> > grep "^$(git rev-parse $rev) " revs || return
> > done
> >
> > I am faster by... a lot. Like, seconds instead of minutes.
>
> I'm fine either way. I just thought you would not want 9 separate
> invocations of grep ;-)
I don't.
I like the unnecessary test_commit calls even less ;-)
And yes, we could avoid those `grep` calls, I know. By something as
convoluted as
revs="$(cat revs)" &&
for rev in $(git rev-parse E e1 e2 e3 e4 e5 e6 e7 e8)
do
case "$LF$revs" in
*"$LF$rev "*) ;; # okay
*) echo "Missing: $rev">&2; return 1;;
esac
done
Is this really what you would call an easy-to-understand test? Maybe for
you, a Unix oldtimer and shell scripting king.
Ciao,
Dscho
