Hi, and now for the review...
On Tue, 26 Jun 2018, Johannes Schindelin wrote: > On Tue, 26 Jun 2018, dana wrote: > > > diff --git a/git-rebase--interactive.sh b/git-rebase--interactive.sh > > index 299ded213..a31af6d4c 100644 > > --- a/git-rebase--interactive.sh > > +++ b/git-rebase--interactive.sh > > @@ -222,9 +222,9 @@ $comment_char $(eval_ngettext \ > > EOF > > append_todo_help > > gettext " > > - However, if you remove everything, the rebase will be aborted. > > +However, if you remove everything, the rebase will be aborted. > > > > - " | git stripspace --comment-lines >>"$todo" > > +" | git stripspace --comment-lines >>"$todo" > > > > if test -z "$keep_empty" > > then This does the job, and I am fine with this way of doing things, and there seems to be a lot of precedent doing it this way e.g. in git-bisect.sh. If my ACK is welcome, you hereby have it. Ciao, Johannes
