On Fri, Jun 15, 2018 at 6:20 PM, Junio C Hamano <gits...@pobox.com> wrote:
> SZEDER Gábor <szeder....@gmail.com> writes:
>
>>> +    bitmap=$(ls .git/objects/pack/*.bitmap) &&
>>
>> I think the 'ls' is unnecessary and this would do:
>>
>>   bitmap=.git/objects/pack/*.bitmap
>
> Yuck.

Oh, wow, now this is embarrassing...


> I said "yuck" because the original does not work if there happen to
> be more than (or for that matter, less than) one '.bitmap' file
> there.  But at least as long as there is one, it should work ;-)

Well, the test starts with 'git repack -ad', so there can be only one
bitmap file.  (Unless something is broken, of course, but the second
test would catch that much earlier.)

Reply via email to