On 15/06/18 15:30, Derrick Stolee wrote: > Reported-by: Ramsay Jones <ram...@ramsayjones.plus.com> > Signed-off-by: Derrick Stolee <dsto...@microsoft.com> > --- > ewah/bitmap.c | 8 -------- > 1 file changed, 8 deletions(-) > > diff --git a/ewah/bitmap.c b/ewah/bitmap.c > index 756bdd050e..d61dc6114a 100644 > --- a/ewah/bitmap.c > +++ b/ewah/bitmap.c > @@ -45,14 +45,6 @@ void bitmap_set(struct bitmap *self, size_t pos) > self->words[block] |= EWAH_MASK(pos); > } > > -void bitmap_clear(struct bitmap *self, size_t pos) > -{ > - size_t block = EWAH_BLOCK(pos); > - > - if (block < self->word_alloc) > - self->words[block] &= ~EWAH_MASK(pos); > -} > - > int bitmap_get(struct bitmap *self, size_t pos) > { > size_t block = EWAH_BLOCK(pos); > I haven't read all the patches yet, but what about the extern declaration in ewah/ewok.h? ATB, Ramsay Jones
- Re: security: potential out-of-bound read at ewah_io.c |ewa... Jeff King
- [PATCH 1/3] ewah_read_mmap: bounds-check mmap reads Jeff King
- Re: [PATCH 1/3] ewah_read_mmap: bounds-check mmap ... SZEDER Gábor
- [PATCH 2/3] ewah: drop ewah_deserialize function Jeff King
- [PATCH 3/3] ewah: drop ewah_serialize_native function Jeff King
- Re: [PATCH 3/3] ewah: drop ewah_serialize_native f... Ramsay Jones
- Re: [PATCH 3/3] ewah: drop ewah_serialize_nati... Ramsay Jones
- [PATCH 0/8] Delete unused methods in EWAH ... Derrick Stolee
- [PATCH 4/8] ewah_bitmap: delete unuse... Derrick Stolee
- [PATCH 1/8] ewah/bitmap.c: delete unu... Derrick Stolee
- Re: [PATCH 1/8] ewah/bitmap.c: de... Ramsay Jones
- Re: [PATCH 1/8] ewah/bitmap.c: de... Derrick Stolee
- [PATCH 2/8] ewah/bitmap.c: delete unu... Derrick Stolee
- Re: [PATCH 2/8] ewah/bitmap.c: de... Ramsay Jones
- [PATCH 6/8] ewah_bitmap: delete unuse... Derrick Stolee
- [PATCH 8/8] ewah_io: delete unused 'e... Derrick Stolee
- Re: [PATCH 8/8] ewah_io: delete u... Ramsay Jones
- Re: [PATCH 8/8] ewah_io: delete u... Derrick Stolee
- [PATCH 3/8] ewah_bitmap: delete unuse... Derrick Stolee
- [PATCH 7/8] ewah_io: delete unused 'e... Derrick Stolee
- [PATCH 5/8] ewah_bitmap: delete unuse... Derrick Stolee