Hi Elijah, On Sat, 19 May 2018, Elijah Newren wrote:
> On Sat, May 19, 2018 at 12:32 AM, Johannes Sixt <j...@kdbg.org> wrote: > > Am 19.05.2018 um 04:07 schrieb Elijah Newren: > >> > >> There is really no need for four branches of nearly identical messages > >> when we can store the differences into small variables before printing. > > > > Oh, there is a reason for the repeated message text: translations! Please do > > not play sentence Lego with translated strings. The original code is > > preferable. > > Ah, translations; that makes sense now. I'm still annoyed by the > code, but I retract patch 5 then. Maybe you can remove the temptation for others, too, my replacing your patch 5 with one that adds the code comment "No sentence Lego! Think of our poor translators and refrain from making their life miserable!" or some more appropriate one? Ciao, Dscho
