> On 14 Mar 2018, at 21:43, Junio C Hamano <gits...@pobox.com> wrote: > > Derrick Stolee <sto...@gmail.com> writes: > >> This v6 includes feedback around csum-file.c and the rename of hashclose() >> to finalize_hashfile(). These are the first two commits of the series, so >> they could be pulled out independently. >> >> The only other change since v5 is that I re-ran the performance numbers >> in "commit: integrate commit graph with commit parsing". > > Thanks. > >> Hopefully this version is ready to merge. I have several follow-up topics >> in mind to submit soon after, including: > > A few patches add trailing blank lines and other whitespace > breakages, which will stop my "git merge" later to 'next' and down, > as I have a pre-commit hook to catch them.
@stolee: I run "git --no-pager diff --check $BASE_HASH...$HEAD_HASH" to detect these kinds of things. I run this as part of my "prepare patch" [1] script which is inspired by a similar script originally written by Dscho. Do you think it would make sense to mention (or even recommend) such a script in your awesome GfW CONTRIBUTING.md? - Lars [1] https://github.com/larsxschneider/git-list-helper/blob/master/prepare-patch.sh#L71
