On Mon, Feb 12, 2018 at 8:41 PM, Stefan Beller <sbel...@google.com> wrote: > Add documentation explaining the functions in color.h. > While at it, migrate the function `color_set` into grep.c, > where the only callers are. > > Signed-off-by: Stefan Beller <sbel...@google.com> > --- > diff --git a/color.h b/color.h > @@ -76,22 +76,46 @@ int git_color_config(const char *var, const char *value, > void *cb); > +/* > + * Output the formatted string in the specified color (and then reset to > normal > + * color so subsequent output is uncolored). Omits the color encapsulation if > + * `color` is NULL. The `color_fprintf_ln` prints a new line after resetting > + * the color. BUG: The `color_print_strbuf` prints the given pre-formatted > + * strbuf instead, up to its first NUL character. > + */
"`color_print_strbuf` prints the given pre-formatted strbuf (BUG: but only up to the first NUL character)." Probably not worth a re-roll is Junio can amend it locally.
