On Fri, Jan 26, 2018 at 01:36:58PM +0100, SZEDER Gábor wrote: > When 'test_i18ngrep' can't find the expected pattern, it exits > completely silently; when its negated form does find the pattern that > shouldn't be there, it prints the matching line(s) but otherwise exits > without any error message. This leaves the developer puzzled about > what could have gone wrong. Well, at least it left me puzzled... > > Initially all I wanted to do was to make 'test_i18ngrep' more > informative on failure, but then skeletons started to fall out of the > closet^Wour test suite, and BAM! before I knew it I had 10 patches:
I know the feeling. :) The series overall looks good to me. I left some comments on the approach in the final few patches, but I could live with it as-is, or with the approach Junio suggested. -Peff
