On Fri, Jan 26, 2018 at 01:36:59PM +0100, SZEDER Gábor wrote: > The test 'push --no-progress silences progress but not status' runs > 'test_i18ngrep' without specifying a filename parameter. This has > remained unnoticed since its introduction in e304aeba2 (t5541: test > more combinations of --progress, 2012-05-01), because that > 'test_i18ngrep' is supposed to check that the given pattern is not > present in its input, and of course it won't find that pattern if its > input is empty, (as it comes from /dev/null). This also means that > this test could miss a potential breakage of 'git push --no-progress'.
Oof, embarrassing. Thanks for catching. This and other errors make me wonder if test_i18ngrep ought to take an explicit "-" for stdin, and error out if no file argument is given. That may be overkill, though (and it's not like we wouldn't have the same problem with regular "grep"). -Peff
