On Tue, 2 Jan 2018 16:18:28 -0800
Brandon Williams <bmw...@google.com> wrote:
> Teach remote-curl the 'connect-half-duplex' command which is used to
> establish a half-duplex connection with servers which support protocol
> version 2. This allows remote-curl to act as a proxy, allowing the git
> client to communicate natively with a remote end, simply using
> remote-curl as a pass through to convert requests to http.
>
> Signed-off-by: Brandon Williams <bmw...@google.com>
> ---
> remote-curl.c | 185
> ++++++++++++++++++++++++++++++++++++++++++++++++-
> t/t5701-protocol-v2.sh | 41 +++++++++++
> 2 files changed, 224 insertions(+), 2 deletions(-)
I didn't look at the usage of the curl API in detail, but overall this
looks good. I'm pleasantly surprised that it didn't take so many lines
of code as I expected.
Overall everything looks good, except for the points that I have brought
up in my other e-mails.
> diff --git a/remote-curl.c b/remote-curl.c
> index 4086aa733..b63b06398 100644
> --- a/remote-curl.c
> +++ b/remote-curl.c
[snip]
> +struct proxy_state {
> + char *service_name;
> + char *service_url;
> + char *hdr_content_type;
> + char *hdr_accept;
Maybe document that the above 3 fields (service_url to hdr_accept) are
cached because we need to pass them to curl_easy_setopt() for every
request.
