On 12/11, SZEDER Gábor wrote: > > Make sure that split index doesn't get broken, by running it on travis > > CI. > > > > Run the test suite with split index enabled in linux 64 bit mode, and > > leave split index turned off in 32-bit mode. > > This doesn't accurately describe what the patch does. > Travis CI runs three 64 bit Linux build jobs for us: one compiled with > Clang, one with GCC, and one with GETTEXT_POISON enabled. This patch > enables split index only in the latter build job, but not in the Clang > and GCC build jobs.
You're right, it's my first time using travis CI and I got confused about how the .travis.yml works, thanks for catching that. Will re-phrase the commit message. > > The laternative would be > > to add an extra target in the matrix, enabling split index mode, but > > that would only use additional cycles on travis and would not bring that > > much benefit, as we are still running the test suite in the "vanilla" > > version in the 32-bit mode. > > > > Signed-off-by: Thomas Gummerer <t.gumme...@gmail.com> > > --- > > .travis.yml | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/.travis.yml b/.travis.yml > > index 281f101f31..c83c766dee 100644 > > --- a/.travis.yml > > +++ b/.travis.yml > > @@ -39,7 +39,7 @@ env: > > > > matrix: > > include: > > - - env: GETTEXT_POISON=YesPlease > > + - env: GETTEXT_POISON=YesPlease GIT_TEST_SPLIT_INDEX=YesPlease > > os: linux > > compiler: > > addons: > > -- > > 2.15.1.504.g5279b80103
