Hey Martin,
On Sat, Oct 28, 2017 at 1:34 AM, Martin Ågren <martin.ag...@gmail.com> wrote:
> On 27 October 2017 at 17:06, Pranit Bauva <pranit.ba...@gmail.com> wrote:
>> + for (i = 0; i < argc; i++) {
>> + if (!strcmp(argv[i], "--term-good"))
>> + printf(_("%s\n"), terms->term_good);
>> + else if (!strcmp(argv[i], "--term-bad"))
>> + printf(_("%s\n"), terms->term_bad);
>
> You seem to have lost --term-old and --term-new. I also wonder why these
> would need translating. You break GETTEXT_POISON here, then fix it in
> patch 8/8.
>
> I'm not even sure you need patch 8/8. If I drop these two `_()`, I can
> run `git rebase -ix "make GETTEXT_POISON=Yes test"` on the entire series
> without failure. Patch 8/8 also switches to `test_i18ngrep` for some
> usages of `git branch` and for some checks on `.git/BISECT_START`. I'm
> not sure that's needed.
Maybe. I am not quite familiar with what does GETTEXT_POISON exactly
does, so I will probably investigate further in this.
Regards,
Pranit Bauva
