Jens Lehmann <jens.lehm...@web.de> writes:

> +If you only want to remove the local checkout of a submodule from your
> +work tree without committing that use `git submodule deinit` instead
> +(see linkgit:git-submodule[1]).

I'll add a comma between "without commiting that" and "use X
instead"; it will read better, I think.

> +test_expect_success 'submodule deinit should remove the whole submodule 
> section from .git/config' '
> +     git config submodule.example.foo bar &&
> +     git submodule deinit &&
> +     test -z "$(git config submodule.example.url)" &&
> +     test -z "$(git config submodule.example.foo)"
> +'

This is sufficient, but it might be cleaner to see if

    git config --get-regexp "^submodule\.example\."

results in empty.  Does not make much difference to warrant a re-roll.

> +test_expect_success 'submodule deinit complains only when explicitly used on 
> an uninitialized submodule' '
> +     git submodule deinit &&
> +     test_must_fail git submodule deinit example
> +'
> +
>  test_done

Thanks; will queue.
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to